Wave 8: tech-debt audits, core unit tests, CLI pipe input (W11.1-W11.7)
- W11.1 context_plugin audit (architect-huang): 3 findings on ABI exception safety, strdup null checks, dead g_max_tokens variable. Rating: B. - W11.2 config audit (engineer-chen): identified 74-line TOML parser duplication between config_plugin and config_store, dual-store data isolation, dangling c_str() risk. Rating: C. - W11.3 event_bus + service_registry unit tests (qa-liu): 12 cases total, ctest coverage 2 -> 4 targets, 100% pass. - W11.4 CLI stdin pipe mode (engineer-zhao): isatty detection, single-shot inference path with exit codes 0/1/2/3. - W11.6 scripts/refresh_status.py (engineer-li): 431-line generator that scans 16 profile.md + 5 group.md to regenerate STATUS.md. - W11.7 destructive testing (qa-xu): 10 input scenarios PASS, found bin copy mismatch (BUG-1) plus 3 minor UX bugs for follow-up. Verified: cmake build 0 error, ctest 4/4 pass. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
@@ -33,5 +33,17 @@ performance_log:
|
||||
- "编译: 0 error; 测试: smoke test passed"
|
||||
- "发现: initialize_all() 在首个插件失败时停止,使后续插件无法初始化 (预存 bug, 非本次引入)"
|
||||
- "发现: deepseek/session 插件 Boost JSON 链接错误 (预存问题, 与本次修复无关)"
|
||||
- date: 2026-05-27
|
||||
event: "W11.2 - 审计 config_plugin / ConfigStore 职责划分与跨 DLL 堆合规"
|
||||
rating: success
|
||||
details:
|
||||
- "跨 DLL 堆: 无违规。两个文件均完全使用 STL 容器,无 malloc/free/strdup 直接调用"
|
||||
- "代码重复: config_plugin.cpp:16-90 与 config_store.cpp:10-83 的 TOML 解析器完全相同 (74行)"
|
||||
- "架构问题: 双 ConfigStore 导致数据孤岛 -- host->config_get 与 query_service('config')->get 读不同 store"
|
||||
- "悬垂指针: get() 返回 std::string::c_str() 后释放锁,并发 set 同 key 触发 realloc 导致 dangling"
|
||||
- "线程安全: mutex 基础正确,但 load_file 逐行持锁导致并发 get 可见部分新/旧混合配置"
|
||||
- "服务注册: on_init 内注册正确,但未检查 register_service 返回值 (重复注册返回 -2 被忽略)"
|
||||
- "评级: C (无跨 DLL 堆违规但代码重复 + 双 store 架构 + dangling pointer 需修复)"
|
||||
- "输出: agents/audits/W11.2-config-audit.md"
|
||||
current_groups: []
|
||||
---
|
||||
|
||||
Reference in New Issue
Block a user